Kaartic Sivaraam <[email protected]> writes:
> The commit template adds the optional parts without
> a new line to distinguish them. This results in
> difficulty in interpreting it's content, specifically
> for inexperienced users.
>
> Add new lines to separate the distinct parts of the
> template.
> ---
> I tried writing tests to ensure that the new line is added
> but as it seems to require checking multi-line, special
> options of grep were required to check. I tried the following,
>
> test_expect_success 'new line found before status message' '
> ! (GIT_EDITOR="cat >editor-input" git commit) &&
> grep -Pz "#\n# On branch" editor-input
> '
>
> It worked well locally but seems to make the build with
> GETTEXT_POISON=YesPlease to fail. So, I removed it.
> Not sure how to write a good test for this change, sorry :(
The above is a good way to capture the input to the editor, but the
test with "grep -P" which is not portable would not work well. You
however should be able to prepare an expected output with
cat >expect <<\-EOF &&
... expected contents to editor-input here ...
EOF
and do "test_i18ncmp expect editor-input" instead of "grep -P".
