On Tue, Aug 8, 2017 at 10:11 AM, Kaartic Sivaraam
<[email protected]> wrote:
> Signed-off-by: Kaartic Sivaraam <[email protected]>
> ---
> branch.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
I like this patch.
In submodule.c we quote a lot of things (branches, submodules, paths), so
this is another step to make the output as a whole more consistent.
(Though wondering for non-submodule users, if they perceive it as
inconsistency as other parts of the code may not follow the rigorous quoting)
>
> diff --git a/branch.c b/branch.c
> index ad5a2299b..a40721f3c 100644
> --- a/branch.c
> +++ b/branch.c
> @@ -90,24 +90,24 @@ int install_branch_config(int flag, const char *local,
> const char *origin, const
> if (shortname) {
> if (origin)
> printf_ln(rebasing ?
> - _("Branch %s set up to track remote
> branch %s from %s by rebasing.") :
> - _("Branch %s set up to track remote
> branch %s from %s."),
> + _("Branch '%s' set up to track
> remote branch '%s' from '%s' by rebasing.") :
> + _("Branch '%s' set up to track
> remote branch '%s' from '%s'."),
> local, shortname, origin);
> else
> printf_ln(rebasing ?
> - _("Branch %s set up to track local
> branch %s by rebasing.") :
> - _("Branch %s set up to track local
> branch %s."),
> + _("Branch '%s' set up to track
> local branch '%s' by rebasing.") :
> + _("Branch '%s' set up to track
> local branch '%s'."),
> local, shortname);
> } else {
> if (origin)
> printf_ln(rebasing ?
> - _("Branch %s set up to track remote
> ref %s by rebasing.") :
> - _("Branch %s set up to track remote
> ref %s."),
> + _("Branch '%s' set up to track
> remote ref '%s' by rebasing.") :
> + _("Branch '%s' set up to track
> remote ref '%s'."),
> local, remote);
> else
> printf_ln(rebasing ?
> - _("Branch %s set up to track local
> ref %s by rebasing.") :
> - _("Branch %s set up to track local
> ref %s."),
> + _("Branch '%s' set up to track
> local ref '%s' by rebasing.") :
> + _("Branch '%s' set up to track
> local ref '%s'."),
> local, remote);
> }
> }
> --
> 2.14.0.rc1.434.g6eded367a
>
