Am 08.08.2017 um 23:36 schrieb Ramsay Jones: > > Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com> > --- > > Hi Junio, > > I noticed this while looking into the t3700 failure on cygwin tonight. > Also, I couldn't decide whether or not to add the i18n '_()' brackets > around the message. In the end I didn't, but will happily add them > if you think I should. > > Thanks! > > ATB, > Ramsay Jones > > builtin/add.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/add.c b/builtin/add.c > index e888fb8c5..385b53ae7 100644 > --- a/builtin/add.c > +++ b/builtin/add.c > @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int > force_mode) > continue; > > if (chmod_cache_entry(ce, force_mode) < 0) > - fprintf(stderr, "cannot chmod '%s'", ce->name); > + fprintf(stderr, "cannot chmod '%s'\n", ce->name); > } > } >
FYI: I brought this up yesterday in the original thread, along with a few other observations: https://public-inbox.org/git/3c61d9f6-e0fd-22a4-68e0-89fd9ce9b...@web.de/ Not sure if the discussion can or should be revived after all this time, though; just sending patches like yours might be the way to go. René
