Am 21.08.2017 um 17:48 schrieb Ramsay Jones:
>
> Commit 67a9dfcc00 ("hash-algo: integrate hash algorithm support with
> repo setup", 21-08-2017) added a 'const struct git_hash_algo *hash_algo'
> field to the repository structure, without modifying the initializer
> of the 'the_repo' variable. This does not actually introduce a bug,
> since the '0' initializer for the 'ignore_env:1' bit-field is
> interpreted as a NULL pointer (hence the warning), and the final field
> (now with no initializer) receives a default '0'.
>
> Signed-off-by: Ramsay Jones <[email protected]>
> ---
>
> Hi Brian,
>
> If you need to re-roll your 'bc/hash-algo' branch, could you please
> squash this into the relevant patch.
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> repository.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/repository.c b/repository.c
> index 01af20dee..ceef73614 100644
> --- a/repository.c
> +++ b/repository.c
> @@ -5,7 +5,7 @@
>
> /* The main repository */
> static struct repository the_repo = {
> - NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, &the_index, 0, 0
> + NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, &the_index, NULL,
> 0, 0
This line yells out "designated initializer" to me:
+ .index = &the_index
> };
> struct repository *the_repository = &the_repo;
>
>
