Stefan Beller <sbel...@google.com> writes: > +cc people from that thread > > On Tue, Aug 22, 2017 at 4:30 PM, Jacob Keller <jacob.kel...@gmail.com> wrote: >> On Tue, Aug 22, 2017 at 4:18 PM, Stefan Beller <sbel...@google.com> wrote: >>> On Tue, Aug 22, 2017 at 4:15 PM, Jacob Keller <jacob.kel...@gmail.com> >>> wrote: >>>> Hi, >>>> >>>> I recently found an issue with git-send-email where it does not >>>> properly remove the cruft of an email address when sending using a Cc: >>>> line. >>>> >>>> The specific example is with a commit containing the following Cc line, >>>> >>>> Cc: sta...@vger.kernel.org # 4.10+ >>> >>> Please see and discuss at >>> https://public-inbox.org/git/20170216174924.GB2625@localhost/ >> >> I read that thread, and it addressed the problem of >> >> Cc: <sta...@vger.kernel.org> # 4.10+ >> >> but did not fix this case without the <> around the email address.
Indeed. It detects garbage as "everything after >". I feel really sorry that we need so many iterations to get back to a correct behavior :-(. >> Additionally I just discovered that the behavior here changes pretty >> drastically if you have Email::Validate installed, now it splits the >> address into multiple things: (I'm assuming you mean Email::Address, there's also Email::Valid but I don't think it would modify the behavior) Hmm, I think we reached the point where we should just stop using Email::Address. Patch series follows and should address both points. -- Matthieu Moy http://matthieu-moy.fr
