On 08/23/2017 02:36 PM, Nguyễn Thái Ngọc Duy wrote:
> [...]
> diff --git a/revision.c b/revision.c
> index 8d04516266..0e98444857 100644
> --- a/revision.c
> +++ b/revision.c
> @@ -2133,6 +2133,14 @@ static int handle_revision_pseudo_opt(const char 
> *submodule,
>       int argcount;
>  
>       if (submodule) {
> +             /*
> +              * We need some something like get_submodule_worktrees()
> +              * before we can go through all worktrees of a submodule,
> +              * .e.g with adding all HEADs from --all, which is not
> +              * supported right now, so stick to single worktree.
> +              */
> +             if (!revs->single_worktree)
> +                     die("BUG: --single-worktree cannot be used together 
> with submodule");
>               refs = get_submodule_ref_store(submodule);
>       } else
>               refs = get_main_ref_store();

Tiny nit: s/.e.g/e.g./

> [...]

Michael

Reply via email to