On Tue, 2017-09-05 at 09:05 -0400, Jeff King wrote: > This patch introduces an UNLEAK() macro that lets us do so. > To understand its design, let's first look at some of the > alternatives. >
> This patch adds the UNLEAK() macro and enables it > automatically when Git is compiled with SANITIZE=leak. > It adds some UNLEAK() annotations to show off how the > feature works. On top of other recent leak fixes, these are > enough to get t0000 and t0001 to pass when compiled with > LSAN. My nit of the day ;-) The above paragraphs seems to going against the following guideline of Documentation/SubmittingPatches, Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior. Try to make sure your explanation can be understood -- Kaartic