On Wed, Nov 28, 2012 at 8:33 PM, Junio C Hamano <gits...@pobox.com> wrote: > Felipe Contreras <felipe.contre...@gmail.com> writes: > >> On Wed, Nov 28, 2012 at 5:57 PM, Junio C Hamano <gits...@pobox.com> wrote: >> ... >>> You need a fix for that; didn't I already say "you need a bit more >>> than that"? >> >> I disagree. Most of the contrib scripts are expected to be used as >> they are. > > You are only looking at one of the uses for this script, when there > are two. > > You are correct that distros may install with whatever tweaks of > their own, and to help their tweak process (like the one that > specifically notices "/usr/bin/env python" as you wrote), changing > the "#!/usr/bin/python" to match others would be a good change. > > But that change alone is not sufficient for this one, which is used > from t/ script. You cannot treat this one like import-zips and > hg-to-git that we do not use in-tree. Somewhere before t9020 uses > it, it needs the treatment similar to the rewriting that is done for > git-p4.py to git-p4.
Unless the tests are moved to contrib, which I think is a good practice: should anything in contrib break 'make test'? I don't think so. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
