Jason Merrill wrote: > Previously, svn dcommit of a merge with svn.pushmergeinfo set would > get error messages like "merge parent <X> for <Y> is on branch > svn+ssh://gcc.gnu.org/svn/gcc/trunk, which is not under the git-svn root > svn+ssh://ja...@gcc.gnu.org/svn/gcc!" > > So, let's call remove_username (as we do for svn info) before comparing > rooturl to branchurl. > > Signed-off-by: Jason Merrill <ja...@redhat.com> > Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> > --- > git-svn.perl | 1 + > 1 file changed, 1 insertion(+)
This is indeed Reviewed-by: Jonathan Nieder <jrnie...@gmail.com> though it does need a test --- I have no confidence that this fix will be preserved without one. Anyway, that can happen in a separate patch. Thanks for your work, Jonathan