On Wed, Sep 27, 2017 at 03:51:26PM -0700, Stefan Beller wrote: > In 146fdb0dfe (diff.c: emit_diff_symbol learns about DIFF_SYMBOL_SUMMARY, > 2017-06-29), the conversion from direct printing to the symbol emission > dropped the new line character for renamed, copied and rewritten files. > > Add the emission of a newline, add a test for this case. > > Reported-by: Linus Torvalds <torva...@linux-foundation.org> > Helped-by: Jeff King <p...@peff.net> > Signed-off-by: Stefan Beller <sbel...@google.com> > --- > > Peff, I am undecided about the added 'diff --stat' call as that > uses a completely different code path and would not show the mode > change, but I guess we can just use it to document the current state.
Yeah, I agree it isn't showing much. I was mostly thinking it just made sense to test a bunch of formats across a mode change to make sure they all showed something reasonable. But it's a rather unlikely bug that "--stat" would _start_ showing something that it's not supposed. I suppose that "--patch" should also possibly be included, though I'd be surprised if that isn't covered elsewhere (but then, I was surprised that --summary wasn't covered either). -Peff
