On Tue, Oct 03, 2017 at 08:57:10PM +0100, Thomas Gummerer wrote: > I recently tried to run the git test suite with --valgrind. > Unfortunately it didn't come back completely clean. This patch series > fixes a bunch of these errors, although unfortunately not quite all of > them yet.
Thanks for trying that. I've largely switched to ASan over valgrind because it runs _so_ much faster. Unfortunately it seems to miss these uninitialized-memory cases. I think using SANITIZE=memory would catch these, but it needs some suppressions tuning. The weird "zlib reads uninitialized memory" error is a problem (valgrind sees this, too, but we have suppressions). -Peff
