On Mon, Oct 02, 2017 at 10:56:46AM -0400, Derrick Stolee wrote: > Thanks for the feedback on my previous versions, and for patience > with my inexperience on the mailing list. I tried to respond to all > feedback, but decided to not apply one suggestion:
For what it's worth, the optimizations here look sound overall. Like Junio, I was concerned at the loss of performance from patch 3 at first. After looking at your numbers, though, I think it really is just the cost of oid_to_hex() that is then eliminated in patch 4. I had a few nits to pick on the perf-test setup, but I stupidly sent them in response to v2 (and so missed cc-ing several folks involved in review). I think they apply equally to v3, though. -Peff
