SZEDER Gábor <szeder....@gmail.com> writes: > Maybe you already considered all this WRT that cmd_name_rev() call, I > don't know. In any case, I think at least the subject line should > spell out cmd_diff_index().
Perhaps. The intent was to eradicate cmd_*() used as a subroutine, so I'd rather opt to explain why name_rev() that does not return is OK in this case in the log message without changing anything else. Thanks for looking it over.