Hi Peff,
On Fri, 20 Oct 2017, Jeff King wrote:
> @@ -2350,6 +2357,7 @@ GIT-LDFLAGS: FORCE
> # and the first level quoting from the shell that runs "echo".
> GIT-BUILD-OPTIONS: FORCE
> @echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@+
> + @echo TEST_SHELL_PATH=\''$(subst ','\'',$(TEST_SHELL_PATH_SQ))'\' >$@+
Do we really want to force the test shell path to be hardcoded at runtime?
It may be a better idea not to write this into GIT-BUILD-OPTIONS.
Or alternatively we could prefix the assignment by
test -n "$TEST_SHELL_PATH" ||
or use the pattern
TEST_SHELL_PATH="${TEST_SHELL_PATH:-[...]}"
Ciao,
Dscho
