On 10/23, Stefan Beller wrote: > Signed-off-by: Stefan Beller <sbel...@google.com> > --- > > diff.c | 10 ++-- > diff.h | 1 + > t/t4015-diff-whitespace.sh | 114 > ++++++++++++++++++++++++++++++++++++++++++++- > > See, only 10 lines of code! (and a few more for tests) > > We have run out of space in diff_options.flags,touched_flags. > as we 1<<U31 as the highest bit. We could reuse 1<<9 that is currently > unused (removed in 882749a04f (diff: add --word-diff option that > generalizes --color-words, 2010-04-14)). But that postpones the > real fix for only a short amount of time. > > Ideas welcome how to extend the flag space. (We cannot just make it > a long either, as some arcane architecures have 32 bit longs.)
One simple idea would be to convert the single 'flag' into various bit fields themselves, that way if you need to add a new flag you would just make a new bit field. I'm unaware of any downsides of doing so (though i may be missing something) but doing so would probably cause a bit of code churn. -- Brandon Williams
