From: Jeff Hostetler <jeffh...@microsoft.com> Here is V2 of the list-object filtering. It replaces [1] and reflect a refactoring and simplification of the original.
After much discussion on the "list-object-filter-map" I've replaced it with a regular oidset -- the only need for the map was to store the first observed pathname for each blob, but that itself was of questionable value. I've extended oidmap and oidset to have iterators. These 2 commits could be pulled out and applied on their own, but for now I need them here. There were also several comments on the layout of the filtering API and the layout of the filter source code. I've restructured the filtering routines to put them in the same source file, and made them all static. These are now hidden behind a "factory-like" function with a vtable. This greatly simplifies the code in traverse_commit_list_filtered(). I've added "--filter-ignore-missing" parameter to rev-list and pack-objects to ignore missing objects rather than error out. This allows this patch series to better stand on its own eliminates the need in part 1 for "patch 9" from V1. This is a brute force ignore all missing objects. Later, in part 2 or part 3 when --exclude-promisor-objects is introduced, we will be able to ignore EXPECTED missing objects. Finally, patch 1 in this series is the same [2] which is currently cooking in next. [1] https://public-inbox.org/git/20171024185332.57261-1-...@jeffhostetler.com/ [2] * jh/dir-add-exclude-from-blob (2017-10-27) 1 commit - dir: allow exclusions from blob in addition to file Jeff Hostetler (6): dir: allow exclusions from blob in addition to file oidmap: add oidmap iterator methods oidset: add iterator methods to oidset list-objects: filter objects in traverse_commit_list rev-list: add list-objects filtering support pack-objects: add list-objects filtering Documentation/git-pack-objects.txt | 12 +- Documentation/git-rev-list.txt | 6 +- Documentation/rev-list-options.txt | 34 +++ Makefile | 2 + builtin/pack-objects.c | 28 ++- builtin/rev-list.c | 75 +++++- dir.c | 132 ++++++++--- dir.h | 3 + list-objects-filter-options.c | 119 ++++++++++ list-objects-filter-options.h | 55 +++++ list-objects-filter.c | 408 +++++++++++++++++++++++++++++++++ list-objects-filter.h | 84 +++++++ list-objects.c | 95 ++++++-- list-objects.h | 2 +- oidmap.h | 22 ++ oidset.c | 10 + oidset.h | 36 +++ t/t5317-pack-objects-filter-objects.sh | 369 +++++++++++++++++++++++++++++ t/t6112-rev-list-filters-objects.sh | 225 ++++++++++++++++++ 19 files changed, 1664 insertions(+), 53 deletions(-) create mode 100644 list-objects-filter-options.c create mode 100644 list-objects-filter-options.h create mode 100644 list-objects-filter.c create mode 100644 list-objects-filter.h create mode 100755 t/t5317-pack-objects-filter-objects.sh create mode 100755 t/t6112-rev-list-filters-objects.sh -- 2.9.3
