On 17/11/17 19:49, Jeff Hostetler wrote: > > > On 11/16/2017 2:57 PM, Ramsay Jones wrote: >> >> >> On 16/11/17 18:12, Jeff Hostetler wrote: >>> From: Jonathan Tan <jonathanta...@google.com> >>> >>> Introduce fetch-object, providing the ability to fetch one object from a >>> promisor remote. > [snip] >>> +#include "transport.h" >> >> I note that this still does not #include "fetch_object.h". >> [If you recall, this suppresses a sparse warning]. >> > > Sorry, I missed that. I know I did a DEVELOPER=1 build and > I didn't see a warning, but I'll check again.
Unless you have sparse installed and 'make sparse' as part of your build, you won't see anything. ;-) However, ignore sparse for the moment, if you don't #include the header (interface) file in fetch-object.c, you can't expect the compiler to tell you when there is a mismatch between the interface and implementation. There are some additional sparse warnings associated with these series, ... (hopefully I can find some time tonight) ATB, Ramsay Jones
