Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

[Johannes Sixt]

Am 29.11.2017 um 16:56 schrieb Dan Jacques:
@@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE
                echo "$$FLAGS" >$@; \
            fi
  
+GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
+       $(QUIET_GEN)$(RM) $@ && \
+       INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory instlibdir` 
&& \
+       INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
+       INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
+       sed -e 's=@@PATHSEP@@=$(pathsep)=g' \

This doesn't work, unfortunately. When $(pathsep) is ';', we get an 
incomplete sed expression because ';' is also a command separator in the 
sed language.

+           -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
+           $< >$@+ && \
+       mv $@+ $@
  
  .PHONY: gitweb
  gitweb:

-- Hannes