Hi Johannes, On 04/12/17 10:46 AM, Johannes Schindelin wrote: > Hi Liam, > > On Sun, 3 Dec 2017, Liam Beguin wrote: > >> diff --git a/sequencer.h b/sequencer.h >> index 4e444e3bf1c4..3bb6b0658192 100644 >> --- a/sequencer.h >> +++ b/sequencer.h >> @@ -45,10 +45,12 @@ int sequencer_continue(struct replay_opts *opts); >> int sequencer_rollback(struct replay_opts *opts); >> int sequencer_remove_state(struct replay_opts *opts); >> >> -int sequencer_make_script(int keep_empty, FILE *out, >> - int argc, const char **argv); >> +#define TODO_LIST_KEEP_EMPTY (1U << 0) >> +#define TODO_LIST_SHORTED_IDS (1U << 1) > > Maybe SHORTEN_IDs? And either revert back to transform_todo_ids() or use > SHORTEN_INSNS... >
I'll change it to TODO_LIST_SHORTED_IDs. TODO_LIST_SHORTED_INSNS would suggest the flag changes both parts of the todo. > Maybe also TRANSFORM_TODO_LIST_* and maybe move the #define's above the > transform_todo_ids() function, i.e. one line further down? > >> +int sequencer_make_script(FILE *out, int argc, const char **argv, >> + unsigned flags); >> >> -int transform_todo_insn(int shorten_ids); >> +int transform_todo_insn(unsigned flags); >> int check_todo_list(void); >> int skip_unnecessary_picks(void); >> int rearrange_squash(void); > > Ciao, > Johannes > Thanks, Liam
