Re: [PATCH v5 2/2] launch_editor(): indicate that Git waits for user input

[Lars Schneider]

> On 07 Dec 2017, at 16:48, Lars Schneider <larsxschnei...@gmail.com> wrote:
> 
> 
>> On 07 Dec 2017, at 16:43, Junio C Hamano <gits...@pobox.com> wrote:
>> 
>> lars.schnei...@autodesk.com writes:
>> ...
> 
> How about this?
> 
>                       fprintf(stderr,
>                               _("hint: Waiting for your editor to close the 
> file..."));
>                       if (is_terminal_dumb())
>                               /*
>                                * A dumb terminal cannot erase the line later 
> on. Add a
>                                * newline to separate the hint from subsequent 
> output.
>                                */
>                               fprintf(stderr, "\n")
>                       else
>                               fprintf(stderr, " ")
> 

I forgot the ";" ... switching between programming languages ;-)

                        if (is_terminal_dumb())
                                /*
                                 * A dumb terminal cannot erase the line later 
on. Add a
                                 * newline to separate the hint from subsequent 
output.
                                 */
                                fprintf(stderr, "\n");
                        else
                                fprintf(stderr, " ");



> Can you squash that if you like it?
> 
> Thanks,
> Lars