[email protected] writes:
> From: Torsten Bögershausen <[email protected]>
>
> Replace `git commit -m "comment" ""` with `git commit -m "comment"` to
> remove the empty path spec.
>
> Signed-off-by: Torsten Bögershausen <[email protected]>
> ---
> t/t0027-auto-crlf.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This looks a bit strange. The intent seems to commit all changes
made in the working tree, so I'd understand it if it replaced the
empty string with a single dot.
I also thought that we deprecated use of an empty string as "match
all" pathspec recently, and expected that this to break.
... goes and looks ...
Indeed, 229a95aa ("t0027: do not use an empty string as a pathspec
element", 2017-06-23) does exactly that.
> diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh
> index c2c208fdcd..97154f5c79 100755
> --- a/t/t0027-auto-crlf.sh
> +++ b/t/t0027-auto-crlf.sh
> @@ -370,7 +370,7 @@ test_expect_success 'setup master' '
> echo >.gitattributes &&
> git checkout -b master &&
> git add .gitattributes &&
> - git commit -m "add .gitattributes" "" &&
> + git commit -m "add .gitattributes" &&
> printf "\$Id: 0000000000000000000000000000000000000000
> \$\nLINEONE\nLINETWO\nLINETHREE" >LF &&
> printf "\$Id: 0000000000000000000000000000000000000000
> \$\r\nLINEONE\r\nLINETWO\r\nLINETHREE" >CRLF &&
> printf "\$Id: 0000000000000000000000000000000000000000
> \$\nLINEONE\r\nLINETWO\nLINETHREE" >CRLF_mix_LF &&