From: Alex Bennée <alex.ben...@linaro.org>
We had a regression that broke Linux's get_maintainer.pl. Using
Mail::Address to parse email addresses fixed it, but let's protect
against future regressions.
Note that we need --cc-cmd to be relative because this option doesn't
accept spaces in script names (probably to allow --cc-cmd="executable
--option"), while --smtp-server needs to be absolute.
Patch-edited-by: Matthieu Moy <g...@matthieu-moy.fr>
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Signed-off-by: Matthieu Moy <g...@matthieu-moy.fr>
---
Change since v2:
* Mention relative Vs absolute path in commit message.
* Remove useless "chmod +x"
* Remove useless double quotes
t/t9001-send-email.sh | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
index 4d261c2..a06e5d7 100755
--- a/t/t9001-send-email.sh
+++ b/t/t9001-send-email.sh
@@ -172,6 +172,25 @@ test_expect_success $PREREQ 'cc trailer with various
syntax' '
test_cmp expected-cc commandline1
'
+test_expect_success $PREREQ 'setup fake get_maintainer.pl script for cc
trailer' "
+ write_script expected-cc-script.sh <<-EOF
+ echo 'One Person <o...@example.com> (supporter:THIS (FOO/bar))'
+ echo 'Two Person <t...@example.com> (maintainer:THIS THING)'
+ echo 'Third List <th...@example.com> (moderated list:THIS THING
(FOO/bar))'
+ echo '<f...@example.com> (moderated list:FOR THING)'
+ echo 'f...@example.com (open list:FOR THING (FOO/bar))'
+ echo 's...@example.com (open list)'
+ EOF
+"
+
+test_expect_success $PREREQ 'cc trailer with get_maintainer.pl output' '
+ clean_fake_sendmail &&
+ git send-email -1 --to=recipi...@example.com \
+ --cc-cmd=./expected-cc-script.sh \
+ --smtp-server="$(pwd)/fake.sendmail" &&
+ test_cmp expected-cc commandline1
+'
+
test_expect_success $PREREQ 'setup expect' "
cat >expected-show-all-headers <<\EOF
0001-Second.patch
--
2.7.4
