Hi, On Mon, 8 Jan 2018, Ævar Arnfjörð Bjarmason wrote:
> > On Mon, Jan 08 2018, Dan Jacques jotted: > > From 3/3 (not not send 2 e-mails): > > >+# it. This is intentionally separate from RUNTIME_PREFIX so that notably > >Windows > >+# can hard-code Perl library paths while still enabling RUNTIME_PREFIX > >+# resolution. > > Maybe we covered this in previous submissions, but refresh my memory, > why is the *_PERL define still needed? Reading this explanation doesn't > make sense to me, but I'm probably missing something. If the reason is to accommodate Windows, I think it'd make more sense to change the way Git for Windows handles this, and use the same relative paths (if possible, that is, see the GITPERLLIB problems I mentioned elsewhere and which necessitated https://github.com/git-for-windows/git/commit/3b2f716bd8). BTW I managed to run your `runtime-prefix` branch through VSTS builds on Windows, macOS and Linux and they all pass the test suite. (Including the RUNTIME_PREFIX_PERL=YesPlease setting you added for Travis CI testing.) What do you think? Should we just fold the RUNTIME_PREFIX_PERL handling into RUNTIME_PREFIX and be done with that part? Ciao, Johannes
