Rename some variables for easier reading.
They point not to values, but to arrays.
Added "s" ending so that it could be obvious.
Signed-off-by: Olga Telezhnaia <olyatelezhn...@gmail.com>
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored by: Jeff King <p...@peff.net>
---
ref-filter.c | 60 ++++++++++++++++++++++++++++++------------------------------
1 file changed, 30 insertions(+), 30 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c
index 3f9161707e66b..1426f0c28bce7 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -98,7 +98,7 @@ static struct used_atom {
struct refname_atom refname;
char *head;
} u;
-} *used_atom;
+} *used_atoms;
static int used_atom_cnt, need_tagged, need_symref;
static void color_atom_parser(const struct ref_format *format, struct
used_atom *atom, const char *color_value)
@@ -325,11 +325,11 @@ static void head_atom_parser(const struct ref_format
*format, struct used_atom *
atom->u.head = resolve_refdup("HEAD", RESOLVE_REF_READING, NULL, NULL);
}
-static struct {
+static struct valid_atom {
const char *name;
cmp_type cmp_type;
void (*parser)(const struct ref_format *format, struct used_atom *atom,
const char *arg);
-} valid_atom[] = {
+} valid_atoms[] = {
{ "refname" , FIELD_STR, refname_atom_parser },
{ "objecttype" },
{ "objectsize", FIELD_ULONG },
@@ -410,38 +410,38 @@ static int parse_ref_filter_atom(const struct ref_format
*format,
/* Do we have the atom already used elsewhere? */
for (i = 0; i < used_atom_cnt; i++) {
- int len = strlen(used_atom[i].name);
- if (len == ep - atom && !memcmp(used_atom[i].name, atom, len))
+ int len = strlen(used_atoms[i].name);
+ if (len == ep - atom && !memcmp(used_atoms[i].name, atom, len))
return i;
}
/*
* If the atom name has a colon, strip it and everything after
* it off - it specifies the format for this entry, and
- * shouldn't be used for checking against the valid_atom
+ * shouldn't be used for checking against the valid_atoms
* table.
*/
arg = memchr(sp, ':', ep - sp);
atom_len = (arg ? arg : ep) - sp;
/* Is the atom a valid one? */
- for (i = 0; i < ARRAY_SIZE(valid_atom); i++) {
- int len = strlen(valid_atom[i].name);
- if (len == atom_len && !memcmp(valid_atom[i].name, sp, len))
+ for (i = 0; i < ARRAY_SIZE(valid_atoms); i++) {
+ int len = strlen(valid_atoms[i].name);
+ if (len == atom_len && !memcmp(valid_atoms[i].name, sp, len))
break;
}
- if (ARRAY_SIZE(valid_atom) <= i)
+ if (ARRAY_SIZE(valid_atoms) <= i)
die(_("unknown field name: %.*s"), (int)(ep-atom), atom);
/* Add it in, including the deref prefix */
at = used_atom_cnt;
used_atom_cnt++;
- REALLOC_ARRAY(used_atom, used_atom_cnt);
- used_atom[at].name = xmemdupz(atom, ep - atom);
- used_atom[at].type = valid_atom[i].cmp_type;
+ REALLOC_ARRAY(used_atoms, used_atom_cnt);
+ used_atoms[at].name = xmemdupz(atom, ep - atom);
+ used_atoms[at].type = valid_atoms[i].cmp_type;
if (arg) {
- arg = used_atom[at].name + (arg - atom) + 1;
+ arg = used_atoms[at].name + (arg - atom) + 1;
if (!*arg) {
/*
* Treat empty sub-arguments list as NULL (i.e.,
@@ -450,12 +450,12 @@ static int parse_ref_filter_atom(const struct ref_format
*format,
arg = NULL;
}
}
- memset(&used_atom[at].u, 0, sizeof(used_atom[at].u));
- if (valid_atom[i].parser)
- valid_atom[i].parser(format, &used_atom[at], arg);
+ memset(&used_atoms[at].u, 0, sizeof(used_atoms[at].u));
+ if (valid_atoms[i].parser)
+ valid_atoms[i].parser(format, &used_atoms[at], arg);
if (*atom == '*')
need_tagged = 1;
- if (!strcmp(valid_atom[i].name, "symref"))
+ if (!strcmp(valid_atoms[i].name, "symref"))
need_symref = 1;
return at;
}
@@ -711,7 +711,7 @@ int verify_ref_format(struct ref_format *format)
at = parse_ref_filter_atom(format, sp + 2, ep);
cp = ep + 1;
- if (skip_prefix(used_atom[at].name, "color:", &color))
+ if (skip_prefix(used_atoms[at].name, "color:", &color))
format->need_color_reset_at_eol = !!strcmp(color,
"reset");
}
if (format->need_color_reset_at_eol && !want_color(format->use_color))
@@ -762,7 +762,7 @@ static void grab_common_values(struct atom_value *val, int
deref, struct object
int i;
for (i = 0; i < used_atom_cnt; i++) {
- const char *name = used_atom[i].name;
+ const char *name = used_atoms[i].name;
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
continue;
@@ -775,7 +775,7 @@ static void grab_common_values(struct atom_value *val, int
deref, struct object
v->s = xstrfmt("%lu", sz);
}
else if (deref)
- grab_objectname(name, obj->oid.hash, v, &used_atom[i]);
+ grab_objectname(name, obj->oid.hash, v, &used_atoms[i]);
}
}
@@ -786,7 +786,7 @@ static void grab_tag_values(struct atom_value *val, int
deref, struct object *ob
struct tag *tag = (struct tag *) obj;
for (i = 0; i < used_atom_cnt; i++) {
- const char *name = used_atom[i].name;
+ const char *name = used_atoms[i].name;
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
continue;
@@ -808,7 +808,7 @@ static void grab_commit_values(struct atom_value *val, int
deref, struct object
struct commit *commit = (struct commit *) obj;
for (i = 0; i < used_atom_cnt; i++) {
- const char *name = used_atom[i].name;
+ const char *name = used_atoms[i].name;
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
continue;
@@ -938,7 +938,7 @@ static void grab_person(const char *who, struct atom_value
*val, int deref, stru
const char *wholine = NULL;
for (i = 0; i < used_atom_cnt; i++) {
- const char *name = used_atom[i].name;
+ const char *name = used_atoms[i].name;
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
continue;
@@ -976,7 +976,7 @@ static void grab_person(const char *who, struct atom_value
*val, int deref, stru
if (!wholine)
return;
for (i = 0; i < used_atom_cnt; i++) {
- const char *name = used_atom[i].name;
+ const char *name = used_atoms[i].name;
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
continue;
@@ -1066,7 +1066,7 @@ static void grab_sub_body_contents(struct atom_value
*val, int deref, struct obj
unsigned long sublen = 0, bodylen = 0, nonsiglen = 0, siglen = 0;
for (i = 0; i < used_atom_cnt; i++) {
- struct used_atom *atom = &used_atom[i];
+ struct used_atom *atom = &used_atoms[i];
const char *name = atom->name;
struct atom_value *v = &val[i];
if (!!deref != (*name == '*'))
@@ -1127,7 +1127,7 @@ static void fill_missing_values(struct atom_value *val)
/*
* val is a list of atom_value to hold returned values. Extract
- * the values for atoms in used_atom array out of (obj, buf, sz).
+ * the values for atoms in used_atoms array out of (obj, buf, sz).
* when deref is false, (obj, buf, sz) is the object that is
* pointed at by the ref itself; otherwise it is the object the
* ref (which is a tag) refers to.
@@ -1376,8 +1376,8 @@ static void populate_value(struct ref_array_item *ref)
/* Fill in specials first */
for (i = 0; i < used_atom_cnt; i++) {
- struct used_atom *atom = &used_atom[i];
- const char *name = used_atom[i].name;
+ struct used_atom *atom = &used_atoms[i];
+ const char *name = used_atoms[i].name;
struct atom_value *v = &ref->value[i];
int deref = 0;
const char *refname;
@@ -2059,7 +2059,7 @@ static int cmp_ref_sorting(struct ref_sorting *s, struct
ref_array_item *a, stru
{
struct atom_value *va, *vb;
int cmp;
- cmp_type cmp_type = used_atom[s->atom].type;
+ cmp_type cmp_type = used_atoms[s->atom].type;
int (*cmp_fn)(const char *, const char *);
get_ref_atom_value(a, s->atom, &va);
--
https://github.com/git/git/pull/450
