On Fri, Jan 19, 2018 at 01:20:41PM -0800, Junio C Hamano wrote: > > Documentation/merge-config.txt | 4 ++ > > builtin/merge.c | 2 + > > A+x t/t5573-pull-verify-signatures.sh | 81 ++++++++++++++++++++++++ > > t/t7612-merge-verify-signatures.sh | 45 +++++++++++++ > > 4 files changed, 132 insertions(+) > > I like the concept but given that additions and mode changes are > rare events, I am not so sure if it is worth always wasting three > columns like the above. Assuming that this is solely meant for > human consumption and machine parsability is of no concern, I > actually prefer the output format you said you've been using your > personal fork, e.g. > > Documentation/merge-config.txt | 4 ++ > builtin/merge.c | 2 + > t/t5573-pull-verify-signatures.sh (new, +x) | 81 ++++++++++++++++++++++++ > t/t7612-merge-verify-signatures.sh | 45 +++++++++++++ > > That is > > (1) do not change the starting column at the leftmost end, and > (2) do not permanently allocate the columns for "compact" summary.
I think the patch already does (2). In fact, it computes the max compact-status size (so if you only have "A" and not "A+x", it wastes only the one column). I agree that (1) would save space in some cases, though IMHO it's a little hard to notice. -Peff
