Hi Olga, On Thu, Jan 25, 2018 at 6:20 PM, Оля Тележная <olyatelezhn...@gmail.com> wrote: > Hi everyone, > I haven't sent the code by mailing lists because 25 commits (every > commit in separate message) look like a spam.
Yeah, so now that you added tests, it might be interesting to see if the patch series can be refactored to be shorter or to be clearer. > Please look at my code: > https://github.com/telezhnaya/git/commits/catfile > You could send me any ideas here or in Github. I left some comments on GitHub. My main suggestion is to try to get rid of the is_cat global and if possible to remove the "struct expand_data *cat_file_info" global. > The main idea of the patch is to get rid of using custom formatting in > cat-file and start using general one from ref-filter. > Additional bonus is that cat-file becomes to support many new > formatting commands like %(if), %(color), %(committername) etc. Yeah, that is a really nice result. > I remember I need to rewrite docs, I will do that in the near future. Great, thanks, Christian.
