On Thu, Jan 25, 2018 at 06:59:25PM +0700, Nguyễn Thái Ngọc Duy wrote: > Like v1, these changes keep diffstat generated by format-patch in 72 > columns. This constant is already used in the code, so it's a bit > better than my random "70 or 75" value. > > Granted these hard coded values (both 80 and 72) are not really nice. > But I would wait for somebody to say "I need or want this" before I > add code to make the default configurable. > > Nguyễn Thái Ngọc Duy (2): > format-patch: keep cover-letter diffstat wrapped in 72 columns > format-patch: reduce patch diffstat width to 72
This looks OK to me. There was one head-scratcher in the second patch which I mentioned, but I think it's probably OK. I also notice that we have no tests for diffstat on a cover letter, which might be worth addressing. -Peff
