Phillip Wood <phillip.w...@talktalk.net> writes: > From: Phillip Wood <phillip.w...@dunelm.org.uk> > > Purge the index lines from diffs so we're not hard coding sha1 hash > values in the expected output.
The motivation of this patch is clear, but all-zero object name for missing side of deletion or creation patch should not change when we transition to any hash function. Neither the permission bits shown in the output (and whether the index line has the bits are shown on it in the first place, i.e. the index line of a creation patch does not, whilethe one in a modification patch does). So I am a bit ambivalent about this change. Perhaps have a filter that redacts, instead of removes, selected pieces of information that are likely to change while hash transition, and use that consistently to filter both the expected output and the actual output before comparing?
