On Thu, Feb 15, 2018 at 5:46 AM, Ævar Arnfjörð Bjarmason <ava...@gmail.com> wrote: > In general I'm mildly negative on adding this, for every user like Doron > who'll be less confused by a hack like this, you'll have other users > who'll be confused about git inexplicably working with ~ in the middle > of strings, even though; > > $ echo git init --template ~/path > git init --template /home/avar/path > $ echo git init --template=~/path > git init --template=~/path
If you have a directory named '~', I expect you are already used to prefixing it with './' because '~' will be expanded in many places where you might want to avoid. > I think it makes more sense to just leave such expansion to the shell, > and not try to magically expand it after the fact, since it's both > confusing (user: why does this work with git and not this other > program?), and as shown above changes existing semantics. > > We'll also be setting ourselves up for more disappointed users who'll > notice that e.g. `git clone file://~/path` doesn't work, but `git clone > file://$HOME/path` does, requiring more hacks to expand ~ in more > codepaths. Will they also expact `git log -G~` to find references to > their homedir in their dotfiles.git? > > I think this way lies madness, and it's better to just avoid it. Well. That's a bit extreme, I think if we add this then we handle case by case in future when it makes sense, not blindly expanding '~' everywhere. The problem I have with this --template=~/path is tab-completion actually completes the path, which (mis)leads me to think the command will accept '~/' too. But this looks like a bug in git-completion.bash though, it's a bit eager in completing stuff (or maybe it completes "--template ~/path" and "--template=~/path" the same way). I don't feel strongly about this. I'm OK with dropping these patches if people think it's not a good idea (then I will try to fix git-completion.bash not to complete '~' in this case). > But I think that if we're going to keep it it needs some tests & docs to > point confused users to. -- Duy
