On Sun, Feb 25, 2018 at 12:34 PM, brian m. carlson <sand...@crustytoothpaste.net> wrote: > On Sun, Feb 25, 2018 at 06:18:34PM +0700, Nguyễn Thái Ngọc Duy wrote: >> v3 refines v2 a bit more: >> >> - fix configure typo (and stray words in commit message) >> - use repo_set_hash_algo() instead of reassigning the_hash_algo >> - compare hash algos by format_id >> - catch NULL hash algo, report nicely and suggest GIT_HASH_FIXUP >> >> The last point makes me much happier about keeping this workaround >> around until we are confident we can live without it. Interdiff > > This looks sane to me. > > Reviewed-by: brian m. carlson <sand...@crustytoothpaste.net>
I agree with this version as well. Thanks, Stefan
