On 13 March 2018 at 03:36, Viet Hung Tran <viethtran1...@gmail.com> wrote: > Hello Mr. Schneider, > > Here is my link for the passed CI build I tested on my fork: > https://travis-ci.org/VietHTran/git/builds/352103333 > > In order to test .travis.yml configuration alone, I used a sample python > script call "test.py" that is already successfully tested on my computer > instead of using the git-p4.py like in the patch I submitted since the > git-p4.py file still reports a lot of errors when running pylint. > > It is possible to fix all the git-p4.py errors. However, I think it would > be best to fix each error separately with multiple commits (each should > fix a specific problem such as indentication, variable naming, etc.) > since there are a lot of changes needed to be made in the codes. Since the > microproject requires that I submit one patch, I decided to submit a patch > that includes changes in .travis.yml only. If you like, I can also submit the > patches addressing changes on the git-p4.py that fix the pylint errors.
You can turn down the amount of messages it spews out, at which point it actually becomes quite useful. I had a quick go with the list of enabled checkers found here: https://github.com/ClusterHQ/flocker/blob/master/.pylintrc and it then gives about 40 warnings, all of which look like they could do with fixing. I think fixing them in a few patches would be OK, rather than submitting 40 separate patches. Quite a lot of the warnings are about the use of "file" - I've got a change I'm working on which fixes some of those already. Luke > > Thank you for feedback, > > Viet > > Signed-off-by: Viet Hung Tran <viethtran1...@gmail.com> > --- > .travis.yml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/.travis.yml b/.travis.yml > index 5f5ee4f3b..581d75319 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -46,6 +46,16 @@ matrix: > - docker > before_install: > script: ci/run-linux32-docker.sh > + - env: jobname=Pylint > + compiler: > + addons: > + apt: > + packages: > + - python > + before_install: > + install: pip install --user pylint > + script: pylint git-p4.py > + after_failure: > - env: jobname=StaticAnalysis > os: linux > compiler: > -- > 2.16.2.440.gc6284da >
