On Fri, Mar 23, 2018 at 11:24 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes:
>
>> If you fold this into the previous patch, I am sure that after your 3/9
>> indenting the function properly, the splitting into functions will look
>> more or less like this:
>>
>> -git_rebase__interactive () {
>> +initiate_action () {
>> + action="$1"
>>
>> [... unchanged code ...]
>> +}
>> +
>> +<next function> () {
>> + [... setting up variables ...]
>>
>> [.. unchanged code ...]
>> +}
>> [... more of the same ...]
>> +
>> +git_rebase__interactive () {
>> + initiate_action "$action" &&
>> + <next function> <arguments> &&
>> + ...
>> +}
>>
>> In other words, it would be easier to review and to verify that the
>> previous code is left unchanged (although that would have to be verified
>> manually by applying 3/9 and then looking at the diff with the -w option,
>> anyway).
>
> We are on the same page on this. A series structured to have a step
> that looks exactly like the above would be very pleasant to review.
>
> Thanks for a great suggestion.
SG and I'll rebase on top of my v5 for the first two commits which
I rebased on master.
