On Sat, Mar 24, 2018 at 10:42 AM, Ævar Arnfjörð Bjarmason
<ava...@gmail.com> wrote:
>
> On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote:
>
>> +     if (pack->in_pack_by_idx) {
>> +             if (p->index <= 0)
>> +                     die("BUG: found_pack should be NULL "
>> +                                     "instead of having non-positive 
>> index");
>> +                     e->in_pack_idx = p->index;
>> +     } else
>
> The indentation after the die() here is wrong. GCC complaining about it:
>
>     ./pack-objects.h: In function ‘oe_set_in_pack’:
>     ./pack-objects.h:203:3: warning: this ‘if’ clause does not guard... 
> [-Wmisleading-indentation]
>        if (p->index <= 0)
>        ^~
>     ./pack-objects.h:206:4: note: ...this statement, but the latter is 
> misleadingly indented as if it were guarded by the ‘if’
>         e->in_pack_idx = p->index;
>         ^

Thanks. My gcc reported the same thing but only when not used with ccache, hm...
-- 
Duy

Reply via email to