On Mon, Mar 26, 2018 at 2:04 PM Stefan Beller <sbel...@google.com> wrote:
> On Fri, Mar 23, 2018 at 8:55 AM Nguyễn Thái Ngọc Duy <pclo...@gmail.com> wrote: > > > > The argument name "optional" may mislead the reader to think this > > option could be NULL. But it can't be. While at there, document a bit > > more about struct set_gitdir_args. > > > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> > Reviewed-by: Stefan Beller <sbel...@google.com> Uh, not so fast. Is it worthwhile to align the parameter name in the c file as well?
