I've been working on converting all of git stash to be a builtin, however it's hard to get it all working at once with limited time, so I've moved around half of it to a new stash--helper builtin and called these functions from the shell script. Once this is stabalized, it should be easier to convert the rest of the commands one at a time without breaking anything.
I've sent most of this code before, but that was targetting a full replacement of stash. The code is overall the same, but with some code review changes and updates for internal api changes. Since there seems to be interest from GSOC students who want to work on converting builtins, I figured I should finish what I have that works now so they could build on top of it. Previous threads: v1: https://public-inbox.org/git/20180325173916.GE10909@hank/T/ v2: https://public-inbox.org/git/20180326011426.19159-1-j...@teichroeb.net/ Changes from v2: - Fixed formatting (I keep forgetting to set vim to tabs) - Renamed destroy to free - Redid my tests to validate more (Thanks Johannes) - Deleted more shell code that isn't needed anymore Joel Teichroeb (5): stash: improve option parsing test coverage stash: convert apply to builtin stash: convert drop and clear to builtin stash: convert branch to builtin stash: convert pop to builtin .gitignore | 1 + Makefile | 1 + builtin.h | 1 + builtin/stash--helper.c | 631 ++++++++++++++++++++++++++++++++++++++++++++++++ git-stash.sh | 136 +---------- git.c | 1 + t/t3903-stash.sh | 16 ++ 7 files changed, 659 insertions(+), 128 deletions(-) create mode 100644 builtin/stash--helper.c -- 2.16.2
