Jeff King wrote: > On Wed, Mar 28, 2018 at 01:33:03PM -0700, Jonathan Nieder wrote:
>> When upload-pack gained partial clone support (v2.17.0-rc0~132^2~12, >> 2017-12-08), it was guarded by the uploadpack.allowFilter config item >> to allow server operators to control when they start supporting it. >> >> That config item didn't go far enough, though: it controls whether the >> 'filter' capability is advertised, but if a (custom) client ignores >> the capability advertisement and passes a filter specification anyway, >> the server would handle that despite allowFilter being false. [...] > Great catch. If I understand correctly, this is an issue in the 2.17.0 > release candidates. Is this worth delaying the release? Yes, IMHO this is a release blocker. (To put it another way, if this is going to delay the release, then we need to revert that patch.) Thanks, Jonathan
