On Thu, Mar 29, 2018 at 04:57:26PM +0200, Duy Nguyen wrote:
> On Wed, Mar 28, 2018 at 02:19:32PM -0400, Jeff King wrote:
> >
> > > I will probably rework on top of your chdir-notify instead (and let
> > > yours to be merged earlier)
> >
> > Thanks. I like some of the related changes you made, like including this
> > in the tracing output. That should be easy to do on top of mine, I
> > think.
>
> Yeah. But is it possible to sneak something like this in your series
> (I assume you will reroll anyway)? I could do it separately, but it
> looks nicer if it's split out and merged in individual patches that
> add new chdir-notify call site.
Sure.
> -void chdir_notify_register(chdir_notify_callback cb, void *data)
> +void chdir_notify_register(const char *name,
> + chdir_notify_callback cb,
> + void *data)
> {
> struct chdir_notify_entry *e = xmalloc(sizeof(*e));
> e->cb = cb;
> e->data = data;
> + e->name = name;
> list_add_tail(&e->list, &chdir_notify_entries);
> }
I'm tempted to make a copy of the name here (or at least document that
it must remain valid forever).
-Peff
