On Fri, Mar 30, 2018 at 12:50:50PM -0700, Junio C Hamano wrote: > Jeff King <p...@peff.net> writes: > > > On Fri, Mar 30, 2018 at 12:46:26PM -0700, Junio C Hamano wrote: > > > >> Jeff King <p...@peff.net> writes: > >> > >> > From: Nguyễn Thái Ngọc Duy <pclo...@gmail.com> > >> > > >> > This is so that we can print traces based on this key outside trace.c. > >> > >> "this key" meaning...? GIT_TRACE_SETUP? > > > > I think "based on trace_setup_key". > > > > -Peff > > Yeah, I read, but did not pay enough attention to, the subject X-<.
To be fair, one of our guidelines is that the commit message should not overly rely on the subject line. Though I am certainly guilty of starting many a message with "This". Perhaps: The setup-tracing code is static-local to trace.c. In preparation for new GIT_TRACE_SETUP code outside of trace.c, let's make the trace_key globally available. would be a better commit message. -Peff
