On Mon, Apr 9, 2018 at 6:46 PM, Taylor Blau <[email protected]> wrote:
> Attached is the seventh re-roll of my series to support '--type=<type>'
> instead of '--<type>' in 'git-config(1)'.
>
> Since v6, I have changed only the wording in
> Documentation/git-config.txt, which Eric and I reached consensus upon in
> a sub-thread [1]. Per Eric's suggestion, I have also included an
> inter-diff between this re-roll and the one previous for easier
> consumption.
Thanks, this iteration seems to address the issues raised by my
earlier reviews, and I didn't find anything else upon which to
comment.
I had meant earlier to say that the subject of 2/2:
builtin/config.c: support `--type=<type>` as preferred alias for `--type`
should probably be typeset as:
builtin/config.c: support `--type=<type>` as preferred alias for `--<type>`
but I'd rather not see a re-roll just for that. (Perhaps Junio can
tweak it when queuing.)
