On Sun, Apr 15, 2018 at 4:29 PM, Thomas Gummerer <t.gumme...@gmail.com> wrote: > The main change once again in this series is the user interface. It > feels like we went in a complete circle here now, as this iteration is > bringing the "Preparing ..." line back (although in a slightly > different form than the original), and is moving away from printing > it's own "HEAD is now at..." line again. This also means we don't > need the new hidden option to 'git reset' anymore, which is nice.
I'm glad to see the proposed hidden git-reset option go away, and am likewise happy to see that worktree no longer wants to print "HEAD is now at" itself. I'm much more pleased with the direction this series is now taking than in earlier rounds. It's also much simpler, which is a nice plus. > I do like the new UI more than what we had in the last round (which I > already liked more than the original UI) :) > > To demonstrate the UI updates, let's compare the new UI and the old UI > again. This is the same commands as used for the demonstration in the > last iteration, so please have a look at > <20180331151804.30380-1-t.gumme...@gmail.com> > for an example of what it looked like after the last round. Thanks for presenting examples of the new UI under various conditions. Like you, I find the new "Preparing..." message superior to and much more useful than the original. Aside from the problem pointed out in my review of 2/4 in which it incorrectly shows "detached HEAD" for "git worktree add wt existing-local-branch", I think this series is just about ready, and hope to see it land with the next re-roll. Thanks for working on it.
