> On Wed, Apr 25, 2018 at 10:41:18AM +0200, �var Arnfj�r� Bjarmason wrote: > > 2. Add some config so we can have hook search paths, and ship with a > > default search path for hooks shipped with git. > > I would go for something like this instead of search paths. This > allows you to specify a path to any specific hook in hooks.* config > group. This is basically "$GIT_DIR/hooks directory in config file" but > with lower priority than those in $GIT_DIR/hooks. > > Now we can do something like > > > git -c hooks.post-checkout=/path/to/some/script clone ... > > but of course I would need to fix the FIXME or this hook config is > only effective just this one time. (And of course you could put it in > ~/.gitconfig) > > -- 8< -- > diff --git a/builtin/clone.c b/builtin/clone.c > index 7df5932b85..143413ed2d 100644 > --- a/builtin/clone.c > +++ b/builtin/clone.c > @@ -1063,6 +1063,11 @@ int cmd_clone(int argc, const char **argv, const char > *prefix) > strbuf_addf(&branch_top, "refs/remotes/%s/", option_origin); > } > > + /* > + * FIXME: we should keep all custom config settings via > + * "git -c ..." in $GIT_DIR/config. > + */ > +
We definitely should not, see the difference between 'git -c ... clone url' and 'git clone -c ... url' BTW, wouldn't running git clone --template=/path/to/template/dir/with/hooks/ invoke the post-checkout hook in there?
