On 30.04.18 17:33, Elijah Newren wrote: > Hi, > > On Sun, Apr 29, 2018 at 11:35 PM, <tbo...@web.de> wrote: >> From: Torsten Bögershausen <tbo...@web.de> >> >> On HFS (which is the default Mac filesystem prior to High Sierra), >> unicode names are "decomposed" before recording. >> On APFS, which appears to be the new default filesystem in Mac OS High >> Sierra, filenames are recorded as specified by the user. >> >> APFS continues to allow the user to access it via any name >> that normalizes to the same thing. >> >> This difference causes t0050-filesystem.sh to fail two tests. >> >> Improve the test for a NFD/NFC in test-lib.sh: >> Test if the same file can be reached in pre- and decomposed unicode. >> >> Reported-By: Elijah Newren <new...@gmail.com> >> Signed-off-by: Torsten Bögershausen <tbo...@web.de> >> --- >> t/test-lib.sh | 7 +------ >> 1 file changed, 1 insertion(+), 6 deletions(-) >> >> diff --git a/t/test-lib.sh b/t/test-lib.sh >> index ea2bbaaa7a..e206250d1b 100644 >> --- a/t/test-lib.sh >> +++ b/t/test-lib.sh >> @@ -1106,12 +1106,7 @@ test_lazy_prereq UTF8_NFD_TO_NFC ' > > I'm not sure what "NFD" and "NFC" stand for, but I suspect the test > prerequisite name may be specific to how HFS handled things. If so, > should it be renamed from UTF8_NFD_TO_NFC to something else, such as > UTF8_NORMALIZATION?
NFD and NFC both come from the unicode standard, and are just taken "as is" into the Git world: https://en.wikipedia.org/wiki/Unicode_equivalence If you are otherwise happy with the patch, would it be possible to run it on your system ? (I don't have a High Sierra box, but I am confident that the test work for you). The other comments may be addressed later, may be. In any case, they should go into a different commit.
