On Wed,  2 May 2018 17:53:56 -0700
Stefan Beller <sbel...@google.com> wrote:

>       $name is the name of the relevant submodule section in `.gitmodules`,
>       $sm_path is the path of the submodule as recorded in the superproject,
>       $sha1 is the commit as recorded in the superproject, and
> -     $toplevel is the absolute path to the top-level of the superproject.
> +     $toplevel is the absolute path to its direct superproject, such that
> +     $toplevel/$sm_path is the absolute path of the submodule.
>       Note that to avoid conflicts with '$PATH' on Windows, the '$path'
>       variable is now a deprecated synonym of '$sm_path' variable.
>       Any submodules defined in the superproject but not checked out are

Ah, I commented on patch 2 before reading patch 3 properly. I think that
if you follow my suggestions on patch 2, it will be obvious that
$toplevel/$sm_path is the absolute path of the submodule, so that this
patch is no longer needed.

Reply via email to