Hi Peff,
On Sat, 5 May 2018, Jeff King wrote:
> On Fri, May 04, 2018 at 05:34:32PM +0200, Johannes Schindelin wrote:
>
> > This builtin does not do a whole lot so far, apart from showing a usage
> > that is oddly similar to that of `git tbdiff`. And for a good reason:
> > the next commits will turn `branch-diff` into a full-blown replacement
> > for `tbdiff`.
>
> One minor point about the name: will it become annoying as a tab
> completion conflict with git-branch?
I did mention this in the commit message of 18/18:
Without this patch, we would only complete the `branch-diff` part but
not the options and other arguments.
This of itself may already be slightly disruptive for well-trained
fingers that assume that `git bra<TAB>ori<TAB>mas<TAB>` would expand to
`git branch origin/master`, as we now no longer automatically append a
space after completing `git branch`: this is now ambiguous.
> It feels really petty complaining about the name, but I just want to
> raise the point, since it will never be easier to change than right now.
I do hear you. Especially since I hate `git cherry` every single time that
I try to tab-complete `git cherry-pick`.
> (And no, I don't really have another name in mind; I'm just wondering if
> "subset" names like this might be a mild annoyance in the long run).
They totally are, and if you can come up with a better name, I am really
interested in changing it before this hits `next`, even.
Ciao,
Dscho
