On Wed, May 09, 2018 at 10:55:34PM +0200, Martin Ågren wrote: > This is take two of my attempt at making almost all `struct lock_file`s > non-static. All patches have been equipped with more detailed commit > messages. The only diff that has changed is patch 3/5, where I now take > a small step towards gentle error-handling, rather than going in the > opposite direction. > > Thanks all for the valuable feedback on v1. I could have saved everyone > some trouble by writing better commit messages from the start, and > probably also by using `--thread` when formatting the patches...
Indeed, the world would be a more efficient place if we all did everything perfectly all the time. Sadly, that's not how it works. :) This version looks good to me. Thanks for modernizing things. I don't think it's worth re-rolling, but one thing to think about for future cleanups: you split the patches by touched area, not by functionality. So the first three patches have a "while we're here..." that has to explain why dropping the "static" is the right thing over and over. If you instead did the error-handling fixes independently first, then you could lump the "static" cleanups together with one explanation (possibly even just as part of the 4th patch). -Peff
