On Sat, May 12, 2018 at 10:45:23AM +0200, René Scharfe wrote: > Why is fetch called outside of the test? Its output is shown among the > test messages, where it doesn't belong: > > ok 23 - overrides work between mixed transfer/upload-pack hideRefs > From /home/lsr/src/git/t/trash directory.t5512-ls-remote/ > * [new branch] master -> origin/master > ok 24 - ls-remote --symref
Heh, I just noticed this yesterday, too, but ran out of time before writing up the patch. > -- >8 -- > Subject: [PATCH] t5512: run git fetch inside test > > Do the preparatory fetch inside the test of ls-remote --symref to avoid > cluttering the test output and to be able to catch unexpected fetch > failures. Yep, this looks obviously correct. -Peff
