On Sun, May 13, 2018 at 09:34:03AM +0200, Johannes Sixt wrote: > Am 13.05.2018 um 04:24 schrieb brian m. carlson: > > diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh > > index dac3f349a3..42b3e11207 100755 > > --- a/t/t4014-format-patch.sh > > +++ b/t/t4014-format-patch.sh > > @@ -578,7 +578,9 @@ test_expect_success 'excessive subject' ' > > rm -rf patches/ && > > git checkout side && > > + before=$(git rev-parse --short $(git hash-object file)) && > > for i in 5 6 1 2 3 A 4 B C 7 8 9 10 D E F; do echo "$i"; done >>file && > > + after=$(git rev-parse --short $(git hash-object file)) && > > It would be better to avoid process expansion in command arguments, because > the shell does not diagnose failures. This is preferable: > > before=$(git hash-object file) && > before=$(git rev-parse --short $before) &&
I considered that and assumed it would be all right because if git hash-object failed, we wouldn't get anything on stdout. However, I agree that your approach is more robust, so I'll reroll with that change. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
