On Sun, May 20, 2018 at 3:17 AM, Martin Ågren <martin.ag...@gmail.com> wrote: > +/** > + * Add formatted string to the end of `list`. This function ignores > + * the value of `list->strdup_strings` and always appends a freshly > + * allocated string, so you will probably not want to use it with > + * `strdup_strings = 0`. > + */ > +struct string_list_item *string_list_appendf(struct string_list *list, > + const char *fmt, ...); > +
Would it make sense to verify that strdup_strings == 0? I guess we'd have to use die or BUG(), but that would mean that the program could crash.. I doubt this could be verified at compilation time.... Thanks, Jake
