Coverity reported that the recently-added call to add_packed_git() in index-pack.c actually does nothing. It's right, and it turns out this is a minor bug in the .gitmodules fsck patches in v2.17.1. I say minor because it errs on the side of complaining too much (so it's not a security problem) and it comes up only in what I can imagine is a pretty obscure case.
The second patch here fixes that. But while looking into it, I notice a much older breakage in running "index-pack --strict" outside of a repository entirely. That's fixed by the first patch. [1/2]: prepare_commit_graft: treat non-repository as a noop [2/2]: index-pack: handle --strict checks of non-repo packs builtin/index-pack.c | 8 ++++++-- commit.c | 3 +++ t/t5300-pack-object.sh | 6 ++++++ t/t7415-submodule-names.sh | 10 ++++++++++ 4 files changed, 25 insertions(+), 2 deletions(-) -Peff
