On Sat, Jun 2, 2018 at 12:32 AM, Nguyễn Thái Ngọc Duy <pclo...@gmail.com> wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com>
> ---
> diff --git a/transport.c b/transport.c
> @@ -875,7 +875,7 @@ struct transport *transport_get(struct remote *remote,
> const char *url)
> ret->progress = isatty(2);
>
> if (!remote)
> - die("No remote provided to transport_get()");
> + BUG("No remote provided to transport_get()");
Did you want to downcase "No" or just didn't bother since it's not
intended for end-user?
It looks like most callers of transport_get() won't pass NULL for
'remote' so this makes sense as a BUG(). A couple callers,
archive.c:run_remote_archiver() and fetch-object.c:fetch_refs(), get
the remote via remote_get() but don't check for NULL before
dereferencing it (before even calling this function), so will crash if
remote_get() ever returns NULL (assuming that it ever could in those
cases).
